[WIP] Category autocomplete: allow user to toggle making group name searchable #2211
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
postonsundays
changed the title
|
Does this need to be behind a setting? I don't think it will cause much trouble at all if searching by group was always on. |
|
@youngcw Based on the previous discussion in #1615, it seems like most people are split down the middle on this, so including the option as a general config seems like the most accessible solution. Having it tucked away in the settings also keeps the main interface simple, since users aren't likely to change this option frequently and it can be referenced in the docs. |
|
@postonsundays For this project we are actively trying to keep the number of settings to a minimum. Considering we used to search groups but removed it, I think the best course of action would be to put in a feature request and wait a while to see how the greater user base feels. I'm going to close this for the time being. |
A bit of user friction I've encountered when categorizing a transaction is not being able to see all the categories I have under a certain group (e.g. Health). The app used to have the group name to the list of values being searched so that by simply typing "Health", I can see all the possible sub-categories in one place, but was removed following a discussion around UX in #1615.
A potential solution is giving users the choice whether they want this extra bit of functionality. This PR will add the option to toggle including group names in the categories in the dashboard settings and creates a more comprehensive
filterCategorySuggestionsfunction in theCategoryAutocompletecomponent to check if the user has enabled this feature.Main changes
ui.categorySuggestionsGroupNamesto local preferencesExtra work
CategorySuggestiontype in the file so the expanded object withgroupcomponent can be used in more methods